Repository navigation
Record the CCITT fixtures and what the first attempt established - #21
Merged
Merged
Conversation
Two Pillow-written strips and the bitmap they must produce are committed beside the other image fixtures, with the TIFF-strip extraction method and the two facts the decoder attempt established: the raw bitmap is the complement of Pillow tobytes(), and a line may start with a zero-length white run whose transition at 0 shifts every later b1 if it is not recorded. No production code: the CCITT decoder is the next slice, and this commit makes it start from data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No production code: this records the data and the findings so the CCITT slice (the next one in ADR-005) starts from a fixture rather than from a description.
tests/.../Assets/parity/images/ccitt-g4.bin— 26 bytes, Group 4, a 16 x 16 bilevel fixture (a diagonal and a 6 x 6 block), written by Pillow 13.0.0 through libtiff.ccitt-g3.bin— the same bitmap as Group 3 one-dimensional, 68 bytes.ccitt-expected.txt— the 16 x 16 geometry and the 32-byte bitmap Pillow decodes (tobytes(), 1 is white).docs/adr/0005-image-filter-decoders.md— the extraction method (the same one that producedlzw-tiff-strip.bin) and the two facts the first decoder attempt established:tobytes(), so the test has to state the matchingBlackIs1;b1— which is where the Group 4 fixture currently stops (line 12).Why no decoder
The first attempt decoded the Group 4 fixture's first twelve lines correctly and then failed on the 2D transition parity. Committing a half-working decoder would wire a broken filter into samples, so it is reverted; the fixture and the findings are the durable part.
Evidence
dotnet build -c Release→ 0 warnings, 0 errors;dotnet test→ 1234 passed, 0 failed on each leg (no test changed).